fix: return BadMethodCallException when trying to close a non-existing prepared statement

Author: fpoy

system/Database/BasePreparedQuery.php

@@ -152,7 +152,7 @@ abstract public function _getResult();
     public function close(): bool
     {
         if (! isset($this->statement)) {
-            return true;
+            throw new BadMethodCallException('Cannot call close on a non-existing prepared statement.');
         }
 
         try {

tests/system/Database/Live/PreparedQueryTest.php

@@ -43,7 +43,11 @@ protected function tearDown(): void
         parent::tearDown();
 
         if ($this->query !== null) {
-            $this->query->close();
+            try {
+                $this->query->close();
+            } catch (BadMethodCallException $e) {
+                $this->query = null;
+            }
         }
     }
 
@@ -162,12 +166,20 @@ public function testDeallocatePreparedQuery()
 
         $this->query->close();
 
+        // Try to execute a non-existing prepared statement
         try {
             $this->query->execute('bar', '[email protected]', 'GB');
         } catch (BadMethodCallException $e) {
             $this->assertSame('You must call prepare before trying to execute a prepared statement.', $e->getMessage());
         }
 
+        // Try to close a non-existing prepared statement
+        try {
+            $this->query->close();
+        } catch (BadMethodCallException $e) {
+            $this->assertSame('Cannot call close on a non-existing prepared statement.', $e->getMessage());
+        }
+
         $this->seeInDatabase($this->db->DBPrefix . 'user', ['name' => 'foo', 'email' => '[email protected]']);
         $this->dontSeeInDatabase($this->db->DBPrefix . 'user', ['name' => 'bar', 'email' => '[email protected]']);
     }