Skip to content

Commit 87db593

Browse files
authored
Merge pull request #8609 from kenjis/deprecate-BaseConfig-services
refactor: remove unnecessary BaseService::$services assignment
2 parents 15ad0a3 + 3c71913 commit 87db593

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

system/Config/BaseService.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,8 @@ class BaseService
167167
* A cache of other service classes we've found.
168168
*
169169
* @var array
170+
*
171+
* @deprecated 4.5.0 No longer used.
170172
*/
171173
protected static $services = [];
172174

@@ -335,7 +337,6 @@ protected static function buildServicesCache(): void
335337

336338
if ($classname !== Services::class) {
337339
self::$serviceNames[] = $classname;
338-
static::$services[] = new $classname();
339340
}
340341
}
341342
}

user_guide_src/source/changelogs/v4.5.0.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -450,6 +450,8 @@ Deprecations
450450

451451
- **CodeIgniter:** The ``determinePath()`` method has been deprecated. No longer
452452
used.
453+
- **Services:** The ``BaseService::$services`` property has been deprecated. No
454+
longer used.
453455
- **Response:** The constructor parameter ``$config`` has been deprecated. No
454456
longer used.
455457
- **Filters:**

0 commit comments

Comments
 (0)