Merge pull request #6333 from kenjis/fix-error_404

fix:  404 page might display Exception message in production environment

Author: kenjis

app/Views/errors/html/error_404.php

@@ -73,7 +73,7 @@
         <h1>404 - File Not Found</h1>
 
         <p>
-            <?php if (! empty($message) && $message !== '(null)') : ?>
+            <?php if (ENVIRONMENT !== 'production') : ?>
                 <?= nl2br(esc($message)) ?>
             <?php else : ?>
                 Sorry! Cannot seem to find the page you were looking for.

phpstan-baseline.neon.dist

@@ -445,11 +445,6 @@ parameters:
 			count: 1
 			path: system/Database/Seeder.php
 
-		-
-			message: "#^Expression on left side of \\?\\? is not nullable\\.$#"
-			count: 1
-			path: system/Debug/Exceptions.php
-
 		-
 			message: "#^Property Config\\\\Exceptions\\:\\:\\$sensitiveDataInTrace \\(array\\) in isset\\(\\) is not nullable\\.$#"
 			count: 1

system/Debug/Exceptions.php

@@ -269,7 +269,7 @@ protected function collectVars(Throwable $exception, int $statusCode): array
             'title'   => get_class($exception),
             'type'    => get_class($exception),
             'code'    => $statusCode,
-            'message' => $exception->getMessage() ?? '(null)',
+            'message' => $exception->getMessage(),
             'file'    => $exception->getFile(),
             'line'    => $exception->getLine(),
             'trace'   => $trace,