Skip to content

Commit 9e8786c

Browse files
authored
Merge pull request #8242 from kenjis/fix-validation-field_exists
refactor: Validation rule field_exists
2 parents b4f6af0 + 5f1d0a5 commit 9e8786c

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

system/Validation/Validation.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,8 @@ protected function processRules(
300300
$arrayCallable = $isCallable && is_array($rule);
301301

302302
$passed = false;
303-
$param = false;
303+
/** @var string|null $param */
304+
$param = null;
304305

305306
if (! $isCallable && preg_match('/(.*?)\[(.*)\]/', $rule, $match)) {
306307
$rule = $match[1];
@@ -329,7 +330,7 @@ protected function processRules(
329330
if ($rule === 'field_exists') {
330331
$passed = $set->{$rule}($value, $param, $data, $error, $originalField);
331332
} else {
332-
$passed = ($param === false)
333+
$passed = ($param === null)
333334
? $set->{$rule}($value, $error)
334335
: $set->{$rule}($value, $param, $data, $error, $field);
335336
}
@@ -355,8 +356,6 @@ protected function processRules(
355356
$value = json_encode($value);
356357
}
357358

358-
$param = ($param === false) ? '' : $param;
359-
360359
$fieldForErrors = ($rule === 'field_exists') ? $originalField : $field;
361360

362361
// @phpstan-ignore-next-line $error may be set by rule methods.

0 commit comments

Comments
 (0)