Skip to content

Commit a03ddb1

Browse files
committed
refactor: Fix phpstan isset.offset
1 parent e475fd8 commit a03ddb1

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

system/Database/BaseBuilder.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3182,6 +3182,7 @@ protected function compileWhereHaving(string $qbKey): string
31823182
) {
31833183
continue;
31843184
}
3185+
31853186
// $matches = [
31863187
// 0 => '(test <= foo)', /* the whole thing */
31873188
// 1 => '(', /* optional */
@@ -3191,7 +3192,7 @@ protected function compileWhereHaving(string $qbKey): string
31913192
// 5 => ')' /* optional */
31923193
// ];
31933194

3194-
if (isset($matches[4]) && $matches[4] !== '') {
3195+
if ($matches[4] !== '') {
31953196
$protectIdentifiers = false;
31963197
if (str_contains($matches[4], '.')) {
31973198
$protectIdentifiers = true;

utils/phpstan-baseline/isset.offset.neon

Lines changed: 0 additions & 8 deletions
This file was deleted.

utils/phpstan-baseline/loader.neon

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ includes:
1717
- expr.resultUnused.neon
1818
- function.alreadyNarrowedType.neon
1919
- generator.valueType.neon
20-
- isset.offset.neon
2120
- isset.property.neon
2221
- method.alreadyNarrowedType.neon
2322
- method.childParameterType.neon

0 commit comments

Comments
 (0)