Skip to content

Commit a589af0

Browse files
committed
docs: update pull_request.md
1 parent cb60d93 commit a589af0

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

contributing/pull_request.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,6 @@ The best way to contribute is to fork the CodeIgniter4 repository, and "clone" t
252252
- Commit messages are expected to be descriptive of why and what you changed specifically. Commit messages like "Fixes #1234" would be asked by the reviewer to be revised. [Atomic commit](https://en.wikipedia.org/wiki/Atomic_commit#Atomic_commit_convention) is recommended. See [Contribution Workflow](./workflow.md#commit-messages) for details.
253253
9. If you have touched PHP code, run static analysis.
254254
- `> composer analyze`
255-
- `> vendor/bin/rector process`
256255
10. Run unit tests on the specific file you modified. If there are no existing tests yet, please create one.
257256
- `> vendor/bin/phpunit tests/system/path/to/file/you/modified`
258257
- Make sure the tests pass to have a higher chance of merging.

0 commit comments

Comments
 (0)