Merge pull request #1157 from samsonasik/rem-isset-host

lonnieezell · web-flow · commit b612bf1bbeaf · 2018-08-26T22:10:26.000-05:00
remove unneeded isset($options[hostname]) when next check is !empty($options[hostname])
diff --git a/system/Router/RouteCollection.php b/system/Router/RouteCollection.php
@@ -1173,7 +1173,7 @@ protected function create(string $verb, string $from, $to, array $options = null
 		$options = array_merge((array)$this->currentOptions, (array)$options);
 
 		// Hostname limiting?
-		if (isset($options['hostname']) && ! empty($options['hostname']))
+		if (! empty($options['hostname']))
 		{
 			// @todo determine if there's a way to whitelist hosts?
 			if (strtolower($_SERVER['HTTP_HOST']) != strtolower($options['hostname']))

Original file line number	Diff line number	Diff line change
`@@ -1173,7 +1173,7 @@ protected function create(string $verb, string $from, $to, array $options = null`
`1173`	`1173`	`$options = array_merge((array)$this->currentOptions, (array)$options);`
`1174`	`1174`
`1175`	`1175`	`// Hostname limiting?`
`1176`		`- if (isset($options['hostname']) && ! empty($options['hostname']))`
	`1176`	`+ if (! empty($options['hostname']))`
`1177`	`1177`	`{`
`1178`	`1178`	`// @todo determine if there's a way to whitelist hosts?`
`1179`	`1179`	`if (strtolower($_SERVER['HTTP_HOST']) != strtolower($options['hostname']))`