Skip to content

Commit bd91d85

Browse files
committed
refactor: rename parameter names
1 parent 9d183d0 commit bd91d85

File tree

2 files changed

+9
-16
lines changed

2 files changed

+9
-16
lines changed

phpstan-baseline.php

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5335,18 +5335,6 @@
53355335
'count' => 1,
53365336
'path' => __DIR__ . '/system/Filters/Filters.php',
53375337
];
5338-
$ignoreErrors[] = [
5339-
// identifier: missingType.iterableValue
5340-
'message' => '#^Method CodeIgniter\\\\Filters\\\\Filters\\:\\:runAfter\\(\\) has parameter \\$filterClasses with no value type specified in iterable type array\\.$#',
5341-
'count' => 1,
5342-
'path' => __DIR__ . '/system/Filters/Filters.php',
5343-
];
5344-
$ignoreErrors[] = [
5345-
// identifier: missingType.iterableValue
5346-
'message' => '#^Method CodeIgniter\\\\Filters\\\\Filters\\:\\:runBefore\\(\\) has parameter \\$filterClasses with no value type specified in iterable type array\\.$#',
5347-
'count' => 1,
5348-
'path' => __DIR__ . '/system/Filters/Filters.php',
5349-
];
53505338
$ignoreErrors[] = [
53515339
// identifier: missingType.iterableValue
53525340
'message' => '#^Method CodeIgniter\\\\Filters\\\\Filters\\:\\:setToolbarToLast\\(\\) return type has no value type specified in iterable type array\\.$#',

system/Filters/Filters.php

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,11 +220,13 @@ public function run(string $uri, string $position = 'before')
220220
}
221221

222222
/**
223+
* @param list<array{0: class-string, 1: list<string>}> $filterClassList [[classname, arguments], ...]
224+
*
223225
* @return RequestInterface|ResponseInterface|string
224226
*/
225-
private function runBefore(array $filterClasses)
227+
private function runBefore(array $filterClassList)
226228
{
227-
foreach ($filterClasses as $filterClassInfo) {
229+
foreach ($filterClassList as $filterClassInfo) {
228230
$className = $filterClassInfo[0];
229231
$arguments = ($filterClassInfo[1] === []) ? null : $filterClassInfo[1];
230232

@@ -260,9 +262,12 @@ private function runBefore(array $filterClasses)
260262
return $this->request;
261263
}
262264

263-
private function runAfter(array $filterClasses): ResponseInterface
265+
/**
266+
* @param list<array{0: class-string, 1: list<string>}> $filterClassList [[classname, arguments], ...]
267+
*/
268+
private function runAfter(array $filterClassList): ResponseInterface
264269
{
265-
foreach ($filterClasses as $filterClassInfo) {
270+
foreach ($filterClassList as $filterClassInfo) {
266271
$className = $filterClassInfo[0];
267272
$arguments = ($filterClassInfo[1] === []) ? null : $filterClassInfo[1];
268273

0 commit comments

Comments
 (0)