refactor: remove unused $httpVerb

Author: kenjis

system/Router/AutoRouter.php

@@ -50,11 +50,6 @@ final class AutoRouter implements AutoRouterInterface
      */
     private bool $translateURIDashes;
 
-    /**
-     * HTTP verb for the request.
-     */
-    private string $httpVerb;
-
     /**
      * Default namespace for controllers.
      */
@@ -65,13 +60,11 @@ public function __construct(
         string $defaultNamespace,
         string $defaultController,
         string $defaultMethod,
-        bool $translateURIDashes,
-        string $httpVerb
+        bool $translateURIDashes
     ) {
         $this->cliRoutes          = $cliRoutes;
         $this->defaultNamespace   = $defaultNamespace;
         $this->translateURIDashes = $translateURIDashes;
-        $this->httpVerb           = $httpVerb;
 
         $this->controller = $defaultController;
         $this->method     = $defaultMethod;

system/Router/AutoRouterImproved.php

@@ -104,16 +104,13 @@ final class AutoRouterImproved implements AutoRouterInterface
     /**
      * @param class-string[] $protectedControllers
      * @param string         $defaultController    Short classname
-     *
-     * @deprecated $httpVerb is deprecated. No longer used.
      */
-    public function __construct(// @phpstan-ignore-line
+    public function __construct(
         array $protectedControllers,
         string $namespace,
         string $defaultController,
         string $defaultMethod,
-        bool $translateURIDashes,
-        string $httpVerb
+        bool $translateURIDashes
     ) {
         $this->protectedControllers = $protectedControllers;
         $this->namespace            = rtrim($namespace, '\\');

system/Router/Router.php

@@ -151,17 +151,15 @@ public function __construct(RouteCollectionInterface $routes, ?Request $request
                     $this->collection->getDefaultNamespace(),
                     $this->collection->getDefaultController(),
                     $this->collection->getDefaultMethod(),
-                    $this->translateURIDashes,
-                    $this->collection->getHTTPVerb()
+                    $this->translateURIDashes
                 );
             } else {
                 $this->autoRouter = new AutoRouter(
                     $this->collection->getRoutes('CLI', false), // @phpstan-ignore-line
                     $this->collection->getDefaultNamespace(),
                     $this->collection->getDefaultController(),
                     $this->collection->getDefaultMethod(),
-                    $this->translateURIDashes,
-                    $this->collection->getHTTPVerb()
+                    $this->translateURIDashes
                 );
             }
         }

tests/system/Router/AutoRouterImprovedTest.php

@@ -42,15 +42,14 @@ protected function setUp(): void
         $this->collection      = new RouteCollection(Services::locator(), $moduleConfig, new Routing());
     }
 
-    private function createNewAutoRouter(string $httpVerb = 'GET', $namespace = 'CodeIgniter\Router\Controllers'): AutoRouterImproved
+    private function createNewAutoRouter($namespace = 'CodeIgniter\Router\Controllers'): AutoRouterImproved
     {
         return new AutoRouterImproved(
             [],
             $namespace,
             $this->collection->getDefaultController(),
             $this->collection->getDefaultMethod(),
-            true,
-            $httpVerb
+            true
         );
     }
 
@@ -84,7 +83,7 @@ public function testAutoRouteFindsModuleDefaultControllerAndMethodGet()
 
         $this->collection->setDefaultController('Index');
 
-        $router = $this->createNewAutoRouter('GET', 'App/Controllers');
+        $router = $this->createNewAutoRouter('App/Controllers');
 
         [$directory, $controller, $method, $params]
             = $router->getRoute('test', 'GET');
@@ -99,7 +98,7 @@ public function testAutoRouteFindsDefaultControllerAndMethodPost(): void
     {
         $this->collection->setDefaultController('Index');
 
-        $router = $this->createNewAutoRouter('post');
+        $router = $this->createNewAutoRouter();
 
         [$directory, $controller, $method, $params]
             = $router->getRoute('/', 'POST');