refactor: replace empty()

kenjis · kenjis · commit c6857817b4c1 · 2024-06-22T14:57:53.000+09:00
diff --git a/phpstan-baseline.php b/phpstan-baseline.php
@@ -3106,7 +3106,7 @@
 $ignoreErrors[] = [
 	// identifier: empty.notAllowed
 	'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
-	'count' => 3,
+	'count' => 2,
 	'path' => __DIR__ . '/system/Database/OCI8/Connection.php',
 ];
 $ignoreErrors[] = [
diff --git a/system/Database/OCI8/Connection.php b/system/Database/OCI8/Connection.php
@@ -632,7 +632,7 @@ protected function buildDSN()
         }
 
         $isEasyConnectableHostName = $this->hostname !== '' && ! str_contains($this->hostname, '/') && ! str_contains($this->hostname, ':');
-        $easyConnectablePort       = ! empty($this->port) && ctype_digit((string) $this->port) ? ':' . $this->port : '';
+        $easyConnectablePort       = ($this->port !== '') && ctype_digit((string) $this->port) ? ':' . $this->port : '';
         $easyConnectableDatabase   = $this->database !== '' ? '/' . ltrim($this->database, '/') : '';
 
         if ($isEasyConnectableHostName && ($easyConnectablePort !== '' || $easyConnectableDatabase !== '')) {

Original file line number	Diff line number	Diff line change
`@@ -632,7 +632,7 @@ protected function buildDSN()`
`632`	`632`	`}`
`633`	`633`
`634`	`634`	`$isEasyConnectableHostName = $this->hostname !== '' && ! str_contains($this->hostname, '/') && ! str_contains($this->hostname, ':');`
`635`		`- $easyConnectablePort = ! empty($this->port) && ctype_digit((string) $this->port) ? ':' . $this->port : '';`
	`635`	`+ $easyConnectablePort = ($this->port !== '') && ctype_digit((string) $this->port) ? ':' . $this->port : '';`
`636`	`636`	`$easyConnectableDatabase = $this->database !== '' ? '/' . ltrim($this->database, '/') : '';`
`637`	`637`
`638`	`638`	`if ($isEasyConnectableHostName && ($easyConnectablePort !== '' \|\| $easyConnectableDatabase !== '')) {`