Merge pull request #5340 from kenjis/fix-tests-FilesystemHelperTest

kenjis · web-flow · commit d4db7b22dc8f · 2021-11-17T17:44:04.000+09:00
test: fix FilesystemHelperTest
diff --git a/tests/system/Helpers/FilesystemHelperTest.php b/tests/system/Helpers/FilesystemHelperTest.php
@@ -37,11 +37,12 @@ protected function setUp(): void
             'simpleFile'    => 'A tap-tap-tapping upon my door',
             '.hidden'       => 'There is no spoon',
         ];
+
+        helper('filesystem');
     }
 
     public function testDirectoryMapDefaults()
     {
-        helper('filesystem');
         $this->assertTrue(function_exists('directory_map'));
 
         $expected = [
@@ -65,7 +66,6 @@ public function testDirectoryMapDefaults()
 
     public function testDirectoryMapShowsHiddenFiles()
     {
-        helper('filesystem');
         $this->assertTrue(function_exists('directory_map'));
 
         $expected = [
@@ -257,7 +257,7 @@ public function testDeleteFilesFailure()
 
     public function testGetFilenames()
     {
-        $this->assertTrue(function_exists('delete_files'));
+        $this->assertTrue(function_exists('get_filenames'));
 
         // Not sure the directory names should actually show up
         // here but this matches v3.x results.
@@ -279,7 +279,7 @@ public function testGetFilenames()
 
     public function testGetFilenamesWithHidden()
     {
-        $this->assertTrue(function_exists('delete_files'));
+        $this->assertTrue(function_exists('get_filenames'));
 
         // Not sure the directory names should actually show up
         // here but this matches v3.x results.

Original file line number	Diff line number	Diff line change
`@@ -37,11 +37,12 @@ protected function setUp(): void`
`37`	`37`	`'simpleFile' => 'A tap-tap-tapping upon my door',`
`38`	`38`	`'.hidden' => 'There is no spoon',`
`39`	`39`	`];`
	`40`	`+`
	`41`	`+ helper('filesystem');`
`40`	`42`	`}`
`41`	`43`
`42`	`44`	`public function testDirectoryMapDefaults()`
`43`	`45`	`{`
`44`		`- helper('filesystem');`
`45`	`46`	`$this->assertTrue(function_exists('directory_map'));`
`46`	`47`
`47`	`48`	`$expected = [`
`@@ -65,7 +66,6 @@ public function testDirectoryMapDefaults()`
`65`	`66`
`66`	`67`	`public function testDirectoryMapShowsHiddenFiles()`
`67`	`68`	`{`
`68`		`- helper('filesystem');`
`69`	`69`	`$this->assertTrue(function_exists('directory_map'));`
`70`	`70`
`71`	`71`	`$expected = [`
`@@ -257,7 +257,7 @@ public function testDeleteFilesFailure()`
`257`	`257`
`258`	`258`	`public function testGetFilenames()`
`259`	`259`	`{`
`260`		`- $this->assertTrue(function_exists('delete_files'));`
	`260`	`+ $this->assertTrue(function_exists('get_filenames'));`
`261`	`261`
`262`	`262`	`// Not sure the directory names should actually show up`
`263`	`263`	`// here but this matches v3.x results.`
`@@ -279,7 +279,7 @@ public function testGetFilenames()`
`279`	`279`
`280`	`280`	`public function testGetFilenamesWithHidden()`
`281`	`281`	`{`
`282`		`- $this->assertTrue(function_exists('delete_files'));`
	`282`	`+ $this->assertTrue(function_exists('get_filenames'));`
`283`	`283`
`284`	`284`	`// Not sure the directory names should actually show up`
`285`	`285`	`// here but this matches v3.x results.`