Skip to content

Commit d875dd0

Browse files
authored
Merge pull request #5316 from kenjis/fix-tests-markTestSkipped
test: add $this->markTestSkipped() when extension not loaded
2 parents 929a5a2 + 96b2646 commit d875dd0

File tree

5 files changed

+8
-6
lines changed

5 files changed

+8
-6
lines changed

tests/system/Cache/Handlers/MemcachedHandlerTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,10 @@ protected function setUp(): void
3737
{
3838
parent::setUp();
3939

40+
if (! extension_loaded('memcached')) {
41+
$this->markTestSkipped('Memcached extension not loaded.');
42+
}
43+
4044
$this->config = new Cache();
4145

4246
$this->handler = new MemcachedHandler($this->config);

tests/system/Cache/Handlers/RedisHandlerTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ protected function setUp(): void
3636
{
3737
parent::setUp();
3838

39+
if (! extension_loaded('redis')) {
40+
$this->markTestSkipped('redis extension not loaded.');
41+
}
42+
3943
$this->config = new Cache();
4044

4145
$this->handler = new RedisHandler($this->config);

tests/system/Images/BaseHandlerTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ protected function setUp(): void
3434
{
3535
if (! extension_loaded('gd')) {
3636
$this->markTestSkipped('The GD extension is not available.');
37-
38-
return;
3937
}
4038

4139
// create virtual file system

tests/system/Images/GDHandlerTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ protected function setUp(): void
3333
{
3434
if (! extension_loaded('gd')) {
3535
$this->markTestSkipped('The GD extension is not available.');
36-
37-
return;
3836
}
3937

4038
// create virtual file system

tests/system/Images/ImageMagickHandlerTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ protected function setUp(): void
3434
{
3535
if (! extension_loaded('imagick')) {
3636
$this->markTestSkipped('The ImageMagick extension is not available.');
37-
38-
return;
3937
}
4038

4139
$this->root = WRITEPATH . 'cache/';

0 commit comments

Comments
 (0)