Skip to content

Commit d89bca7

Browse files
committed
fix: try/catch to FilterFilder::find()
1 parent 938a576 commit d89bca7

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

system/Commands/Utilities/Routes.php

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
use CodeIgniter\Commands\Utilities\Routes\AutoRouterImproved\AutoRouteCollector as AutoRouteCollectorImproved;
1919
use CodeIgniter\Commands\Utilities\Routes\FilterCollector;
2020
use CodeIgniter\Commands\Utilities\Routes\SampleURIGenerator;
21-
use CodeIgniter\Exceptions\PageNotFoundException;
2221
use Config\Services;
2322

2423
/**
@@ -100,15 +99,7 @@ public function run(array $params)
10099
foreach ($routes as $route => $handler) {
101100
if (is_string($handler) || $handler instanceof Closure) {
102101
$sampleUri = $uriGenerator->get($route);
103-
104-
try {
105-
$filters = $filterCollector->get($method, $sampleUri);
106-
} catch (PageNotFoundException $e) {
107-
$filters = [
108-
'before' => ['<unknown>'],
109-
'after' => ['<unknown>'],
110-
];
111-
}
102+
$filters = $filterCollector->get($method, $sampleUri);
112103

113104
$tbody[] = [
114105
strtoupper($method),

system/Commands/Utilities/Routes/FilterFinder.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
namespace CodeIgniter\Commands\Utilities\Routes;
1313

14+
use CodeIgniter\Exceptions\PageNotFoundException;
1415
use CodeIgniter\Filters\Filters;
1516
use CodeIgniter\Router\Exceptions\RedirectException;
1617
use CodeIgniter\Router\Router;
@@ -67,6 +68,11 @@ public function find(string $uri): array
6768
'before' => [],
6869
'after' => [],
6970
];
71+
} catch (PageNotFoundException $e) {
72+
return [
73+
'before' => ['<unknown>'],
74+
'after' => ['<unknown>'],
75+
];
7076
}
7177
}
7278
}

0 commit comments

Comments
 (0)