fix: do not unset statement after closing it, instead set to null

Author: fpoy

phpstan-baseline.neon.dist

@@ -115,11 +115,6 @@ parameters:
 			count: 1
 			path: system/Database/Migration.php
 
-		-
-			message: "#^Property CodeIgniter\\\\Database\\\\BasePreparedQuery\\:\\:\\$statement \\(object\\|resource\\) in isset\\(\\) is not nullable\\.$#"
-			count: 1
-			path: system/Database/BasePreparedQuery.php
-
 		-
 			message: "#^Cannot access property \\$errno on bool\\|object\\|resource\\.$#"
 			count: 1
@@ -225,11 +220,6 @@ parameters:
 			count: 1
 			path: system/Database/MySQLi/PreparedQuery.php
 
-		-
-			message: "#^Property CodeIgniter\\\\Database\\\\BasePreparedQuery\\:\\:\\$statement \\(object\\|resource\\) in isset\\(\\) is not nullable\\.$#"
-			count: 1
-			path: system/Database/MySQLi/PreparedQuery.php
-
 		-
 			message: "#^Cannot access property \\$field_count on object\\|resource\\|false\\.$#"
 			count: 1
@@ -270,21 +260,11 @@ parameters:
 			count: 1
 			path: system/Database/MySQLi/Result.php
 
-		-
-			message: "#^Property CodeIgniter\\\\Database\\\\BasePreparedQuery\\:\\:\\$statement \\(object\\|resource\\) in isset\\(\\) is not nullable\\.$#"
-			count: 1
-			path: system/Database/OCI8/PreparedQuery.php
-
 		-
 			message: "#^Strict comparison using \\=\\=\\= between array and false will always evaluate to false\\.$#"
 			count: 1
 			path: system/Database/Postgre/Connection.php
 
-		-
-			message: "#^Property CodeIgniter\\\\Database\\\\BasePreparedQuery\\:\\:\\$statement \\(object\\|resource\\) in isset\\(\\) is not nullable\\.$#"
-			count: 1
-			path: system/Database/Postgre/PreparedQuery.php
-
 		-
 			message: "#^Access to an undefined property CodeIgniter\\\\Database\\\\BaseConnection\\:\\:\\$schema\\.$#"
 			count: 2
@@ -295,11 +275,6 @@ parameters:
 			count: 13
 			path: system/Database/SQLSRV/Forge.php
 
-		-
-			message: "#^Property CodeIgniter\\\\Database\\\\BasePreparedQuery\\:\\:\\$statement \\(object\\|resource\\) in isset\\(\\) is not nullable\\.$#"
-			count: 1
-			path: system/Database/SQLSRV/PreparedQuery.php
-
 		-
 			message: "#^Cannot call method changes\\(\\) on bool\\|object\\|resource\\.$#"
 			count: 1
@@ -370,11 +345,6 @@ parameters:
 			count: 1
 			path: system/Database/SQLite3/PreparedQuery.php
 
-		-
-			message: "#^Property CodeIgniter\\\\Database\\\\BasePreparedQuery\\:\\:\\$statement \\(object\\|resource\\) in isset\\(\\) is not nullable\\.$#"
-			count: 1
-			path: system/Database/SQLite3/PreparedQuery.php
-
 		-
 			message: "#^Cannot call method columnName\\(\\) on object\\|resource\\|false\\.$#"
 			count: 2

system/Database/BasePreparedQuery.php

@@ -25,7 +25,7 @@ abstract class BasePreparedQuery implements PreparedQueryInterface
     /**
      * The prepared statement itself.
      *
-     * @var object|resource
+     * @var object|resource|null
      */
     protected $statement;
 
@@ -158,7 +158,7 @@ public function close(): bool
         try {
             return $this->_close();
         } finally {
-            unset($this->statement);
+            $this->statement = null;
         }
     }