fix: prevent using empty()

ddevsr · ddevsr · commit e4369b7ac556 · 2024-10-07T08:41:15.000+07:00
diff --git a/phpstan-baseline.php b/phpstan-baseline.php
@@ -5470,7 +5470,7 @@
 $ignoreErrors[] = [
 	// identifier: empty.notAllowed
 	'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
-	'count' => 11,
+	'count' => 10,
 	'path' => __DIR__ . '/system/HTTP/CURLRequest.php',
 ];
 $ignoreErrors[] = [
diff --git a/system/HTTP/CURLRequest.php b/system/HTTP/CURLRequest.php
@@ -650,7 +650,7 @@ protected function setCURLOptions(array $curlOptions = [], array $config = [])
         }
 
         // Resolve IP
-        if (! empty($config['force_ip_resolve'])) {
+        if (array_key_exists('force_ip_resolve', $config) && $config['force_ip_resolve']) {
             $protocolVersion = $config['force_ip_resolve'];
 
             if ($protocolVersion === 'v4') {

Original file line number	Diff line number	Diff line change
`@@ -650,7 +650,7 @@ protected function setCURLOptions(array $curlOptions = [], array $config = [])`
`650`	`650`	`}`
`651`	`651`
`652`	`652`	`// Resolve IP`
`653`		`- if (! empty($config['force_ip_resolve'])) {`
	`653`	`+ if (array_key_exists('force_ip_resolve', $config) && $config['force_ip_resolve']) {`
`654`	`654`	`$protocolVersion = $config['force_ip_resolve'];`
`655`	`655`
`656`	`656`	`if ($protocolVersion === 'v4') {`