Skip to content

Commit e4ff053

Browse files
authored
refactor: fix isset.property errors (#9522)
1 parent 50b3f57 commit e4ff053

File tree

4 files changed

+5
-18
lines changed

4 files changed

+5
-18
lines changed

system/Autoloader/Autoloader.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ public function initialize(Autoload $config, Modules $modules)
123123
$this->files = $config->files;
124124
}
125125

126-
if (isset($config->helpers)) {
126+
if ($config->helpers !== []) {
127127
$this->helpers = [...$this->helpers, ...$config->helpers];
128128
}
129129

system/Email/Email.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ class Email
393393
/**
394394
* mbstring.func_overload flag
395395
*
396-
* @var bool
396+
* @var bool|null
397397
*/
398398
protected static $func_overload;
399399

@@ -403,8 +403,9 @@ class Email
403403
public function __construct($config = null)
404404
{
405405
$this->initialize($config);
406+
406407
if (! isset(static::$func_overload)) {
407-
static::$func_overload = (extension_loaded('mbstring') && ini_get('mbstring.func_overload'));
408+
static::$func_overload = extension_loaded('mbstring') && ini_get('mbstring.func_overload');
408409
}
409410
}
410411

utils/phpstan-baseline/isset.property.neon

Lines changed: 0 additions & 13 deletions
This file was deleted.

utils/phpstan-baseline/loader.neon

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# total 3575 errors
1+
# total 3573 errors
22
includes:
33
- argument.type.neon
44
- assign.propertyType.neon
@@ -11,7 +11,6 @@ includes:
1111
- deadCode.unreachable.neon
1212
- empty.notAllowed.neon
1313
- generator.valueType.neon
14-
- isset.property.neon
1514
- method.alreadyNarrowedType.neon
1615
- method.childParameterType.neon
1716
- method.childReturnType.neon

0 commit comments

Comments
 (0)