feat: QueryBuilder insert/update support Time

Author: kenjis

system/Database/BaseBuilder.php

@@ -14,6 +14,7 @@
 use Closure;
 use CodeIgniter\Database\Exceptions\DatabaseException;
 use CodeIgniter\Database\Exceptions\DataException;
+use CodeIgniter\I18n\Time;
 use InvalidArgumentException;
 
 /**
@@ -2697,7 +2698,7 @@ protected function objectToArray($object)
         $array = [];
 
         foreach (get_object_vars($object) as $key => $val) {
-            if ((! is_object($val) || $val instanceof RawSql) && ! is_array($val)) {
+            if ((! is_object($val) || $val instanceof RawSql || $val instanceof Time) && ! is_array($val)) {
                 $array[$key] = $val;
             }
         }

system/Database/BaseConnection.php

@@ -14,6 +14,7 @@
 use Closure;
 use CodeIgniter\Database\Exceptions\DatabaseException;
 use CodeIgniter\Events\Events;
+use CodeIgniter\I18n\Time;
 use stdClass;
 use Throwable;
 
@@ -1247,6 +1248,10 @@ public function escape($str)
                 return $str->__toString();
             }
 
+            if ($str instanceof Time) {
+                $str = $str->toDatabase();
+            }
+
             return "'" . $this->escapeString($str) . "'";
         }
 

tests/system/Database/Builder/InsertTest.php

@@ -14,8 +14,10 @@
 use CodeIgniter\Database\Exceptions\DatabaseException;
 use CodeIgniter\Database\Query;
 use CodeIgniter\Database\RawSql;
+use CodeIgniter\I18n\Time;
 use CodeIgniter\Test\CIUnitTestCase;
 use CodeIgniter\Test\Mock\MockConnection;
+use Locale;
 
 /**
  * @internal
@@ -101,6 +103,26 @@ public function testInsertObjectWithRawSql()
         $this->assertSame($expectedSQL, str_replace("\n", ' ', $builder->getCompiledInsert()));
     }
 
+    public function testInsertObjectWithTimeWithLocaleFa()
+    {
+        $currentLocale = Locale::getDefault();
+        Locale::setDefault('fa');
+
+        $builder = $this->db->table('jobs');
+
+        $time       = Time::parse('2022-08-29 13:00');
+        $insertData = (object) [
+            'id'        => 1,
+            'insert_at' => $time,
+        ];
+        $builder->testMode()->insert($insertData, true);
+
+        $expectedSQL = 'INSERT INTO "jobs" ("id", "insert_at") VALUES (1, \'2022-08-29 13:00:00\')';
+        $this->assertSame($expectedSQL, str_replace("\n", ' ', $builder->getCompiledInsert()));
+
+        Locale::setDefault($currentLocale);
+    }
+
     /**
      * @see https://github.com/codeigniter4/CodeIgniter4/issues/5365
      */

tests/system/Database/Builder/UpdateTest.php

@@ -13,9 +13,11 @@
 
 use CodeIgniter\Database\BaseBuilder;
 use CodeIgniter\Database\Exceptions\DatabaseException;
+use CodeIgniter\I18n\Time;
 use CodeIgniter\Test\CIUnitTestCase;
 use CodeIgniter\Test\Mock\MockConnection;
 use CodeIgniter\Test\Mock\MockQuery;
+use Locale;
 
 /**
  * @internal
@@ -168,6 +170,34 @@ public function testUpdateWithSetAsBoolean()
         $this->assertSame($expectedBinds, $builder->getBinds());
     }
 
+    public function testUpdateWithSetAsTimeWithLocaleFa()
+    {
+        $currentLocale = Locale::getDefault();
+        Locale::setDefault('fa');
+
+        $builder = new BaseBuilder('users', $this->db);
+
+        $time = Time::parse('2022-08-29 13:00');
+        $builder->testMode()->set('last_active', $time)->where('id', 1)->update();
+
+        $expectedSQL = 'UPDATE "users" SET "last_active" = \'2022-08-29 13:00:00\' WHERE "id" = 1';
+        $this->assertSame($expectedSQL, str_replace("\n", ' ', $builder->getCompiledUpdate()));
+
+        $expectedBinds = [
+            'last_active' => [
+                $time,
+                true,
+            ],
+            'id' => [
+                1,
+                true,
+            ],
+        ];
+        $this->assertSame($expectedBinds, $builder->getBinds());
+
+        Locale::setDefault($currentLocale);
+    }
+
     public function testUpdateWithSetAsArray()
     {
         $builder = new BaseBuilder('jobs', $this->db);