Skip to content

[Rector] Apply Rector: SimplifyRegexPatternRector #4806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2021
Merged

[Rector] Apply Rector: SimplifyRegexPatternRector #4806

merged 1 commit into from
Jun 9, 2021

Conversation

samsonasik
Copy link
Member

Simplify regex pattern to known ranges with SimplifyRegexPatternRector rule.

Checklist:

  • Securely signed commits

MGatner
MGatner approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think these kind of PRs qualify for our "coding standard" release so feel free to merge.

@samsonasik samsonasik merged commit 18f5611 into codeigniter4:develop Jun 9, 2021
@samsonasik samsonasik deleted the apply-rector-simplify-regex branch June 9, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @MGatner @paulbalandan