Import global symbols #4890
Closed
Import global symbols #4890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalandan
force-pushed
the
import-global-symbols
branch
from
5a9877b to
a1d9b72
Compare
|
Not sure what happened here. 🤔 |
paulbalandan
force-pushed
the
import-global-symbols
branch
from
a1d9b72 to
1af6535
Compare
|
I know this was what we agreed on, but seeing it in action makes me realize: this is a lot of extra lines. I wonder if at some point there is a diminishing return between the scoping performance gains versus the overall line and file size of the framework? We should calculate the difference and maybe look into running some benchmarks against both versions. |
1 task
paulbalandan
force-pushed
the
import-global-symbols
branch
2 times, most recently
from
c0c06da to
4a985fc
Compare
paulbalandan
force-pushed
the
import-global-symbols
branch
from
4a985fc to
2ab9ab1
Compare
paulbalandan
added
the
blocked
|
Closing this for now. The cost of resolving merge conflicts and maintaining PR up to date with latest develop is way too much than its perceived benefits. I can just recreate this when the time comes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the result of the internal discussion whether to import global symbols (classes, functions, constants) or to fully prepending them with
T_NS_SEPARATOR.This PR imports all internal global symbols to speed up scope resolution. Take note that this imports only the native/internal symbols. This means that this does not import user-defined constants and functions exposed to the global namespace.
Linebreaks separating imports of classes, constants and functions are manually added in accordance with PSR-12.
Checklist: