Skip to content

Add dropKey method to Forge #5171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 15, 2021
Merged

Add dropKey method to Forge #5171

merged 8 commits into from
Oct 15, 2021

Conversation

ytetsuro
Copy link
Contributor

@ytetsuro ytetsuro commented Oct 3, 2021 •
edited by kenjis
Loading

Description

Closes #5164

Add dropKey method.
After this is merged, the following PR also needs to be fixed.
#2487

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ytetsuro ytetsuro force-pushed the fix/#5164_add_dropKey_method branch from e321e4d to b075a35 Compare October 3, 2021 16:11
@ytetsuro ytetsuro changed the title Fixed #5164 add dropKey method WIP Fixed #5164 add dropKey method Oct 3, 2021
@kenjis kenjis added the database Issues or pull requests that affect the database layer label Oct 4, 2021
@ytetsuro ytetsuro force-pushed the fix/#5164_add_dropKey_method branch 2 times, most recently from c110d41 to 316906e Compare October 4, 2021 13:30
@ytetsuro ytetsuro changed the title WIP Fixed #5164 add dropKey method Fixed #5164 add dropKey method Oct 4, 2021
@ytetsuro ytetsuro force-pushed the fix/#5164_add_dropKey_method branch 2 times, most recently from 2cc7a01 to b5e776c Compare October 4, 2021 18:11
@ytetsuro ytetsuro force-pushed the fix/#5164_add_dropKey_method branch from b5e776c to 022940a Compare October 5, 2021 16:06
@ytetsuro
Copy link
Contributor Author

ytetsuro commented Oct 5, 2021

Please review.

kenjis
kenjis reviewed Oct 6, 2021
View reviewed changes
kenjis
kenjis reviewed Oct 6, 2021
View reviewed changes
kenjis
kenjis reviewed Oct 6, 2021
View reviewed changes
kenjis
kenjis reviewed Oct 6, 2021
View reviewed changes
kenjis
kenjis reviewed Oct 6, 2021
View reviewed changes
@paulbalandan paulbalandan changed the title Fixed #5164 add dropKey method Add dropKey method to Forge Oct 6, 2021
@ytetsuro ytetsuro mentioned this pull request Oct 11, 2021
Merged
5 tasks
kenjis
kenjis reviewed Oct 15, 2021
View reviewed changes
kenjis
kenjis approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonnieezell lonnieezell merged commit 0045a6f into codeigniter4:develop Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev: Database Forge should support dropping keys
3 participants
@ytetsuro @lonnieezell @kenjis