Skip to content

fix: number_to_currency() error on PHP 8.1 #5454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 11, 2021

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 11, 2021

Description
Fixes #5452
Follow-up #4883

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

NumberFormatter::setAttribute(): Passing null to parameter #2 ($value) of type int|float is deprecated
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Dec 11, 2021
@samsonasik samsonasik merged commit db24b0b into codeigniter4:develop Dec 11, 2021
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the fix-number_to_currency branch December 11, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: number_to_currency error on NumberFormatter::setAttribute() using default parameter values
3 participants