Skip to content

change dies() to php's function name die() #5987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2022
Merged

change dies() to php's function name die() #5987

merged 1 commit into from
May 10, 2022

Conversation

sba
Copy link
Contributor

@sba sba commented May 10, 2022

dies() may be linguistically more correct, but I would write die() here

@sba
change dies() to php's function name die()
f798da4 
dies() may be linguistically more correct, but I would write die() here
@kenjis kenjis merged commit 5ccb503 into codeigniter4:develop May 10, 2022
@kenjis
Copy link
Member

kenjis commented May 10, 2022

It indicates PHP code (the language construct), so die() is correct.
Thank you.

@sba sba deleted the patch-2 branch May 10, 2022 12:43
@kenjis kenjis added the documentation Pull requests for documentation only label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sba @kenjis