Skip to content

docs: add "Updating Your Branch" in contributing/workflow.md #6045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2022
Merged

docs: add "Updating Your Branch" in contributing/workflow.md #6045

merged 2 commits into from
Jun 1, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 29, 2022

Description
The step after pushing PR is missing.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

MGatner
MGatner requested changes May 30, 2022
View reviewed changes
@kenjis kenjis requested a review from MGatner May 31, 2022 21:27
MGatner
MGatner approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kenjis kenjis merged commit ad956b4 into codeigniter4:develop Jun 1, 2022
@kenjis kenjis deleted the fix-contributing/workflow.md branch June 1, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb left review comments

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @datamweb @MGatner @paulbalandan