-
Notifications
You must be signed in to change notification settings - Fork 1.9k
4.2.6 Ready code #6495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
4.2.6 Ready code #6495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: update composer scripts
docs: update contributing/workflow.md
at SYSTEMPATH\Validation\FileRules.php:42 Backtrace: 1 [internal function] CodeIgniter\Debug\Exceptions()->errorHandler(2, 'assert(): assert($request instanceof IncomingRequest) failed', 'C:\\laragon\\www\\test\\vendor\\codeigniter4\\framework\\system\\Validation\\FileRules.php', 42, [...])
docs: add about controllers namespace in routing
These are not PHP functions but methods.
locale Is a BCP 47 compliant language tag. See https://www.php.net/manual/en/locale.setdefault.php
docs: update PHPDoc in Entity
test: restore changed locale in Time tests
The new version of PHPStan reported: Ignored error pattern ... in path ... was not matched in reported errors.
------ ------------------------------------------------------------------------------ Line system/Model.php ------ ------------------------------------------------------------------------------ 657 Offset 'data' on array on left side of ?? always exists and is not nullable. 683 Offset 'data' on array on left side of ?? always exists and is not nullable. ------ ------------------------------------------------------------------------------
refactor: fix PHPStan errors
Fix broken caching system when array of allowed parameters used
docs: update Model validation
Fix overlooked coding style violations
Enable `control_structure_braces`
CodeIgniter\Validation\Rules::greater_than_equal_to(): Argument #1 ($str) must be of type ?string, int given
…_line Enable `no_multiple_statements_per_line`
Enable `no_useless_nullsafe_operator`
Enable `statement_indentation`
Add `inline_constructor_arguments` option to `class_definition`
…l_to fix: Strict Validation Rules greater_than/less_than
…e-line Enable `no_trailing_comma_in_singleline`
Enable `single_line_comment_spacing`
Prep for 4.2.6 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.