Skip to content

tests: added test for timezone_select function in Date Helper #6575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2022
Merged

tests: added test for timezone_select function in Date Helper #6575

merged 1 commit into from
Sep 23, 2022

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Sep 23, 2022

Description
Added tests for timezone_select() in Date Helper.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr changed the title tests: added test for timezone_select function tests: added test for timezone_select function in Date Helper Sep 23, 2022
@kenjis kenjis added the testing Pull requests that changes tests only label Sep 23, 2022
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@kenjis kenjis merged commit 09028f6 into codeigniter4:develop Sep 23, 2022
@kenjis
Copy link
Member

kenjis commented Sep 23, 2022

This is outside the scope of this PR, but there are helpers with a newline code of "\n" and helpers with PHP_EOL, which is inconsistent.

It seems "\n" is better, because we use "\n" for view files.

@ddevsr ddevsr deleted the tests-helper-date branch September 24, 2022 00:12
@MGatner
Copy link
Member

MGatner commented Sep 24, 2022

PHP_EOL is "\r\n" on Windows. Generally:

  • Use \n for processing input
  • Use PHP_EOL for CLI output
  • Use PHP_EOL for writing files (unless the format is specified)
  • Use either for web output

If we're looking for a consistent choice for web I'm with @kenjis on "\n".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Pull requests that changes tests only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants