Skip to content

fix: inconsistent new line view in date_helper #6582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2022
Merged

fix: inconsistent new line view in date_helper #6582

merged 1 commit into from
Sep 25, 2022

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Sep 24, 2022

Description
By comment, other helper like form & html using \n to view newline.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Sep 24, 2022
@MGatner MGatner merged commit b9ab936 into codeigniter4:develop Sep 25, 2022
@ddevsr ddevsr deleted the fix-inconsistent-newline branch September 25, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ddevsr @kenjis @MGatner @paulbalandan