Skip to content

fix: script_tag() does not work with CSP #6611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2022
Merged

fix: script_tag() does not work with CSP #6611

merged 1 commit into from
Sep 30, 2022
+27 −1

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 30, 2022

Description
Related #6604

  • add nonce when CSP is enabled

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Sep 30, 2022
@kenjis kenjis force-pushed the fix-add-script-nonce branch from 668f4b4 to acad5b6 Compare September 30, 2022 05:41
MGatner
MGatner approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

datamweb
datamweb approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks🥀

@kenjis kenjis merged commit 48d13b9 into codeigniter4:develop Sep 30, 2022
@kenjis kenjis deleted the fix-add-script-nonce branch September 30, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @datamweb @MGatner