Skip to content

style: fix php-cs-fixer.no-header.php #6693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2022
Merged

style: fix php-cs-fixer.no-header.php #6693

merged 2 commits into from
Oct 15, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 15, 2022

Description

  • fix .php-cs-fixer.no-header.php
  • fix coding style

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

MGatner
MGatner approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

paulbalandan
paulbalandan approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot remember what styling problem I had then but since no problems arise this looks good!

@kenjis kenjis merged commit 44fe2f5 into codeigniter4:develop Oct 15, 2022
@kenjis kenjis deleted the fix-php-cs-fixer.no-header branch October 15, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @paulbalandan