Skip to content

Refactor AlterTableTest #6858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 15, 2022
Merged

Refactor AlterTableTest #6858

merged 3 commits into from
Nov 15, 2022

Conversation

paulbalandan
Copy link
Member

Description

  • Run tests only in SQLite3
  • Use in-memory database so that stray database file is not left

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Nov 14, 2022
@kenjis kenjis merged commit 5de3a98 into codeigniter4:develop Nov 15, 2022
@paulbalandan paulbalandan deleted the refactor-alter-table-test branch November 15, 2022 01:36
@paulbalandan paulbalandan mentioned this pull request Nov 15, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@michalsn michalsn michalsn approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulbalandan @kenjis @michalsn @MGatner