Skip to content

Improve testing for MetadataTest #6869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2022
Merged

Improve testing for MetadataTest #6869

merged 2 commits into from
Nov 16, 2022

Conversation

paulbalandan
Copy link
Member

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added testing Pull requests that changes tests only refactor Pull requests that refactor code labels Nov 15, 2022
@paulbalandan paulbalandan force-pushed the refactor-metadata-test branch from 2c72730 to 2be38e1 Compare November 15, 2022 12:02
@paulbalandan paulbalandan force-pushed the refactor-metadata-test branch from 2be38e1 to 925406d Compare November 15, 2022 12:11
@kenjis kenjis merged commit d57c816 into codeigniter4:develop Nov 16, 2022
@kenjis
Copy link
Member

kenjis commented Nov 16, 2022

This is better!

@paulbalandan paulbalandan deleted the refactor-metadata-test branch November 16, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @kenjis @michalsn