fix: [ViewCells] when there are cells with the same short name, only the first cell is loaded #7686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
added
the
bug
kenjis
commented
Jul 9, 2023
| @@ -178,7 +178,8 @@ protected function determineClass(string $library): array | |||
| } | |||
|
|
|||
| // locate and return an instance of the cell | |||
| $object = Factories::cells($class); | |||
| // @TODO extend Factories to be able to load classes with the same short name. | |||
| $object = class_exists($class) ? new $class() : Factories::cells($class); | |||
There was a problem hiding this comment.
In v4.2.12, just new $class() was called:
CodeIgniter4/system/View/Cell.php
Lines 82 to 83 in 558db23
MGatner
approved these changes
Jul 9, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7684
Checklist: