-
Notifications
You must be signed in to change notification settings - Fork 1.9k
docs: improve Model Event #8324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is only one delete() method.
michalsn
approved these changes
Dec 12, 2023
lonnieezell
approved these changes
Dec 13, 2023
Comment on lines
748
to
751
In the case | ||
of the **insert*()** or **update*()** methods, that will be the key/value pairs that are being inserted into the database. | ||
The | ||
main ``$data`` array will also contain the other values passed to the method, and be detailed in `Event Parameters`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
In the case | |
of the **insert*()** or **update*()** methods, that will be the key/value pairs that are being inserted into the database. | |
The | |
main ``$data`` array will also contain the other values passed to the method, and be detailed in `Event Parameters`_. | |
In the case of the **insert*()** or **update*()** methods, that will be the key/value pairs that are being inserted into the database. | |
The main ``$data`` array will also contain the other values passed to the method, and be detailed in `Event Parameters`_. |
Just joining lines together nicely. Not sure if you meant those to be two paragraphs or one, so adjust as desired.
Comment on lines
753
to
754
The callback method | ||
must return the original ``$data`` array so other callbacks have the full information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
The callback method | |
must return the original ``$data`` array so other callbacks have the full information. | |
The callback method must return the original ``$data`` array so other callbacks have the full information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #8306
Checklist: