refactor: [SQLSRV] convert ENUM to VARCHAR(n) in Forge

system/Database/SQLSRV/Forge.php

@@ -326,8 +326,18 @@ protected function _attributeType(array &$attributes)
                 break;
 
             case 'ENUM':
-                $attributes['TYPE']       = 'TEXT';
-                $attributes['CONSTRAINT'] = null;
+                // in char(n) and varchar(n), the n defines the string length in
+                // bytes (0 to 8,000).
+                // https://learn.microsoft.com/en-us/sql/t-sql/data-types/char-and-varchar-transact-sql?view=sql-server-ver16#remarks
+                $maxLength = max(
+                    array_map(
+                        static fn ($value) => strlen($value),
+                        $attributes['CONSTRAINT']
+                    )
+                );
+
+                $attributes['TYPE']       = 'VARCHAR';
+                $attributes['CONSTRAINT'] = $maxLength;
                 break;
 
             case 'TIMESTAMP':

tests/_support/Database/Migrations/20160428212500_Create_test_tables.php

@@ -85,7 +85,8 @@ public function up(): void
         if ($this->db->DBDriver === 'Postgre') {
             unset(
                 $dataTypeFields['type_real'],
-                $dataTypeFields['type_decimal']
+                $dataTypeFields['type_decimal'],
+                $dataTypeFields['type_enum'],
             );
         }
 
@@ -95,7 +96,6 @@ public function up(): void
 
         if ($this->db->DBDriver === 'Postgre' || $this->db->DBDriver === 'SQLSRV') {
             unset(
-                $dataTypeFields['type_enum'],
                 $dataTypeFields['type_set'],
                 $dataTypeFields['type_mediumtext'],
                 $dataTypeFields['type_double'],

tests/system/Database/Live/GetTest.php

@@ -188,7 +188,8 @@ public function testGetFieldData(): void
             $this->assertNull($typeTest[10]->type_name);  // DATETIME
             $this->assertSame('bigint', $typeTest[11]->type_name); // BIGINT
             $this->assertSame('real', $typeTest[12]->type_name);  // REAL
-            $this->assertSame('decimal', $typeTest[13]->type_name);  // DECIMAL
+            $this->assertSame('varchar', $typeTest[13]->type_name);  // ENUM
+            $this->assertSame('decimal', $typeTest[14]->type_name);  // DECIMAL
         }
     }
 

user_guide_src/source/changelogs/v4.5.0.rst

@@ -376,6 +376,9 @@ Changes
   has been fixed from lowercase to uppercase.
 - **Exceptions:** Unused ``CodeIgniter\Exceptions\AlertError`` and
   ``CodeIgniter\Exceptions\EmergencyError`` were removed.
+- **Forge:** ``SQLSRV`` Forge now converts ``ENUM`` data types to ``VARCHAR(n)``
+  when you add table columns. In previous version, it converted to ``TEXT`` that
+  is deprecated in SQL Server.
 - ``declare(strict_types=1)`` has been added to most framework codebase.
 
 Deprecations

user_guide_src/source/dbmgmt/forge.rst

@@ -158,6 +158,14 @@ TEXT
 ``TEXT`` should not be used on SQLSRV. It is deprecated.
 See `ntext, text, and image (Transact-SQL) - SQL Server | Microsoft Learn <https://learn.microsoft.com/en-us/sql/t-sql/data-types/ntext-text-and-image-transact-sql?view=sql-server-ver16>`_.
 
+ENUM
+^^^^
+
+Not all databases support ``ENUM``.
+
+Starting with v4.5.0, ``SQLSRV`` Forge converts ``ENUM`` data types to ``VARCHAR(n)``.
+Previous versions converted to ``TEXT``.
+
 .. _forge-addfield-default-value-rawsql:
 
 Raw Sql Strings as Default Values