Skip to content

docs: fix sample code in testing/controllers #8493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 1, 2024

Description
namespace CodeIgniter should not be used in app testing.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Feb 1, 2024
michalsn
michalsn previously approved these changes Feb 1, 2024
@michalsn michalsn dismissed their stale review February 1, 2024 12:57

Used namespace seems wrong

@kenjis kenjis force-pushed the docs-testing/controllers branch from cacdc2c to ed7d63e Compare February 2, 2024 00:47
`namespace CodeIgniter` should not be used in app testing.
@kenjis kenjis force-pushed the docs-testing/controllers branch from ed7d63e to 1cd91a9 Compare February 2, 2024 06:43
@kenjis kenjis merged commit a0bbb02 into codeigniter4:develop Feb 2, 2024
@kenjis kenjis deleted the docs-testing/controllers branch February 2, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants