Skip to content

[4.5] test: update asssertion for SQLSRV ENUM #8531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 10, 2024

Description
Follow-up #8478

1) CodeIgniter\Database\Live\SQLSRV\GetFieldDataTest::testGetFieldDataType
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
     )
     7 => Array &8 (
         'name' => 'type_enum'
-        'type' => 'text'
-        'max_length' => 2147483647
+        'type' => 'varchar'
+        'max_length' => 5
         'nullable' => true
         'default' => null
     )

/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Database/Live/AbstractGetFieldDataTest.php:169
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Database/Live/SQLSRV/GetFieldDataTest.php:229

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7851204632/job/21428585497

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added testing Pull requests that changes tests only 4.5 labels Feb 10, 2024
@kenjis
Copy link
Member Author

kenjis commented Feb 10, 2024

Now GA check fails in 4.5. Review this first.

@kenjis kenjis merged commit 5c1bf31 into codeigniter4:4.5 Feb 11, 2024
@kenjis kenjis deleted the test-update-SQLSRV-GetFieldDataTest-enum branch February 11, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Pull requests that changes tests only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants