Skip to content

refactor: remove unnecessary BaseService::$services assignment #8609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2024
Merged

refactor: remove unnecessary BaseService::$services assignment #8609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91fea1a
refactor: remove unnecessary $services assignment
kenjis Mar 5, 2024
3c71913
docs: add changelog
kenjis Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion system/Config/BaseService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,8 @@ class BaseService
* A cache of other service classes we've found.
*
* @var array
*
* @deprecated 4.5.0 No longer used.
*/
protected static $services = [];

Expand Down Expand Up @@ -335,7 +337,6 @@ protected static function buildServicesCache(): void

if ($classname !== Services::class) {
self::$serviceNames[] = $classname;
static::$services[] = new $classname();
}
}
}
Expand Down
2 changes: 2 additions & 0 deletions user_guide_src/source/changelogs/v4.5.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,8 @@ Deprecations

- **CodeIgniter:** The ``determinePath()`` method has been deprecated. No longer
used.
- **Services:** The ``BaseService::$services`` property has been deprecated. No
longer used.
- **Response:** The constructor parameter ``$config`` has been deprecated. No
longer used.
- **Filters:**
Expand Down