Skip to content

docs: improve validation.rst #9011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 4, 2024
Merged

docs: improve validation.rst #9011

merged 3 commits into from
Jul 4, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 30, 2024

Description

  • small improvements

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Jun 30, 2024
ddevsr
ddevsr reviewed Jul 1, 2024
View reviewed changes
user_guide_src/source/libraries/validation.rst
valid_url No Fails if field does not contain (loosely) a
URL. Includes simple strings that could be
hostnames, like "codeigniter".
**Normally,** ``valid_url_strict`` **should
Copy link
Collaborator

@ddevsr ddevsr Jul 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Normally,** ``valid_url_strict`` **should
**Normally**, ``valid_url_strict`` **should

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@kenjis kenjis merged commit cd1f3f5 into codeigniter4:develop Jul 4, 2024
4 checks passed
@kenjis kenjis deleted the docs-validation.rst branch July 4, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddevsr ddevsr ddevsr left review comments

@michalsn michalsn michalsn approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @michalsn @datamweb @ddevsr