Skip to content

chore: skip tests View fixtures from rector #9019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

samsonasik
Copy link
Member

Description

Resolve notice:

Run vendor/bin/rector process --dry-run --no-progress-bar

Warning: ] The following files were skipped as starting with short open tag.    
           Migrate to long open PHP tag first:                                  
                                                                                
           tests/system/View/Views/apples.php                                   
           tests/system/View/Views/broken.php                                   
           tests/system/View/Views/extend.php                                   
           tests/system/View/Views/extend_include.php                           
           tests/system/View/Views/extend_reuse_section.php                     
           tests/system/View/Views/extend_two.php         

they are fixture files, so no need to be scanned by rector.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik samsonasik requested review from kenjis and paulbalandan July 2, 2024 07:14
@samsonasik
Copy link
Member Author

Ready to merge 👍

@samsonasik
Copy link
Member Author

Thank you @kenjis for the review, let's merge ;)

@samsonasik samsonasik merged commit 4151c12 into codeigniter4:develop Jul 2, 2024
10 checks passed
@samsonasik samsonasik deleted the view-fixture-exclude branch July 2, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants