Skip to content

docs: make Model Event Parameters description more precise #9127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2024
Merged

docs: make Model Event Parameters description more precise #9127

merged 1 commit into from
Aug 22, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 17, 2024 •
edited
Loading

Description
Closes #9124
See #8306

  • update descriptions for beforeUpdate/afterUpdate id

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Aug 17, 2024
@kenjis kenjis mentioned this pull request Aug 17, 2024
Closed
@kenjis kenjis merged commit 92337f2 into codeigniter4:develop Aug 22, 2024
4 checks passed
@kenjis kenjis deleted the docs-model-afterUpdate-id branch August 22, 2024 00:04
@kenjis
Copy link
Member Author

kenjis commented Aug 22, 2024

@christianberkman Thank you for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianberkman christianberkman christianberkman approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [Model] $afterUpdate callback, returned ID is null.
2 participants
@kenjis @christianberkman