Skip to content

docs: variable naming adjustments #9324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

andifahruddinakas
Copy link
Contributor

@andifahruddinakas andifahruddinakas commented Dec 15, 2024

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added the documentation Pull requests for documentation only label Dec 15, 2024
@paulbalandan
Copy link
Member

Hi @andifahruddinakas, thanks for your PR. However, we're blocked from merging this because the commits are not GPG-signed. Can you sign them?

@paulbalandan paulbalandan added the GPG-Signing needed Pull requests that need GPG-Signing label Dec 15, 2024
@andifahruddinakas
Copy link
Contributor Author

Hi @andifahruddinakas, thanks for your PR. However, we're blocked from merging this because the commits are not GPG-signed. Can you sign them?

Yes, of course

@paulbalandan paulbalandan removed the GPG-Signing needed Pull requests that need GPG-Signing label Dec 15, 2024
@paulbalandan
Copy link
Member

Closing, reopening to trigger CI checks

@paulbalandan paulbalandan merged commit cc2dcee into codeigniter4:develop Dec 16, 2024
9 checks passed
@andifahruddinakas andifahruddinakas deleted the patch-1 branch December 16, 2024 11:31
@andifahruddinakas
Copy link
Contributor Author

Thank You @paulbalandan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants