Skip to content

refactor: fix missingType.return errors #9523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2025
Merged

refactor: fix missingType.return errors #9523

merged 3 commits into from
Apr 14, 2025

Conversation

warcooft
Copy link
Contributor

Description
Fixes missingType.return errors.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

samsonasik
samsonasik reviewed Apr 13, 2025
View reviewed changes
@warcooft warcooft force-pushed the missing-type-return branch from efd2cee to 60b69cd Compare April 14, 2025 01:03
@warcooft warcooft requested a review from samsonasik April 14, 2025 01:15
@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Apr 14, 2025
@github-actions GitHub Actions
Copy link

👋 Hi, @warcooft!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@github-actions github-actions bot added the stale Pull requests with conflicts label Apr 14, 2025
@paulbalandan paulbalandan changed the title refactor: fix missingType.return errors refactor: fix missingType.return errors Apr 14, 2025
@paulbalandan
Copy link
Member

Thanks, @warcooft, for helping in clearing the phpstan errors! Can you please rebase and regenerate the baseline?

@warcooft warcooft requested a review from paulbalandan April 14, 2025 05:05
@michalsn michalsn removed the stale Pull requests with conflicts label Apr 14, 2025
@samsonasik
Copy link
Member

You need to use rebase instead of merge

@warcooft warcooft force-pushed the missing-type-return branch from ed57498 to f57b12a Compare April 14, 2025 08:47
@warcooft
Copy link
Contributor Author

@samsonasik Just checking, did the rebase finish correctly?

@samsonasik samsonasik merged commit e7bce5f into codeigniter4:develop Apr 14, 2025
49 checks passed
@samsonasik
Copy link
Member

Thank you @warcooft

@warcooft
Copy link
Contributor Author

Thanks for the quick guidance!

@warcooft warcooft deleted the missing-type-return branch April 14, 2025 09:24
@paulbalandan paulbalandan removed their request for review April 14, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@samsonasik samsonasik samsonasik approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

@ddevsr ddevsr ddevsr approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@warcooft @paulbalandan @samsonasik @michalsn @ddevsr