Skip to content

refactor: fix @readonly property errors #9529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025

Conversation

paulbalandan
Copy link
Member

Description
Removes the @immutable class annotation from some config classes. The fact that their usage suggests they are not really immutable (and thus their properties not readonly) means the placement of the PHPDoc is wrong.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Apr 18, 2025
@paulbalandan paulbalandan merged commit bbb65b0 into codeigniter4:develop Apr 19, 2025
49 checks passed
@paulbalandan paulbalandan deleted the readonly-prop branch April 19, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants