fix: use native PHP truthiness for condition evaluation in when()/whenNot() #9576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsn
added
the
bug
lonnieezell
approved these changes
May 23, 2025
paulbalandan
approved these changes
May 23, 2025
|
Thank you @lonnieezell and @paulbalandan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the
when()andwhenNot()methods did not treat certain falsy values like0,'0',null, and empty arrays consistently with native PHP conditionals.The condition checks are now explicitly cast to boolean using
(bool), ensuring consistent and expected behavior across all falsy and truthy values.Fixes #9575
Checklist: