refactor: partial fix errors on Email #9582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsn
reviewed
May 26, 2025
paulbalandan
force-pushed
the
partial-email-refactor
branch
3 times, most recently
from
06437e3 to
b001759
Compare
michalsn
approved these changes
May 27, 2025
This comment was marked as outdated.
This comment was marked as outdated.
paulbalandan
force-pushed
the
partial-email-refactor
branch
from
b001759 to
2eb35a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial refactor. The Email class is very big. Hard to follow the code.
Checklist: