Skip to content

feat: add option to change default behaviour of JSONFormatter max depth #9585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 31, 2025
Merged

feat: add option to change default behaviour of JSONFormatter max depth #9585

merged 4 commits into from
May 31, 2025

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented May 27, 2025 •
edited by paulbalandan
Loading

Description
Added option change behaviour depth JSON Formatter

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added docs needed Pull requests needing documentation write-ups and/or revisions. 4.7 enhancement PRs that improve existing functionalities labels May 27, 2025
@paulbalandan
Copy link
Member

I will merge develop to 4.7 to capture the latest changes in JSONFormatter. Please rebase after that.

@ddevsr ddevsr force-pushed the json-depth-option branch from 21ae5d9 to c96e1b0 Compare May 27, 2025 15:52
@ddevsr ddevsr removed the docs needed Pull requests needing documentation write-ups and/or revisions. label May 27, 2025
michalsn
michalsn reviewed May 29, 2025
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why Psalm is failing - it might be related to recent changes in psalm_autoload.php, but it's unclear. We didn't have any issues before merging into the 4.7 branch. Maybe Paul can help figure it out.

@ddevsr ddevsr requested review from michalsn and paulbalandan May 30, 2025 14:38
@paulbalandan paulbalandan changed the title feat: added options for change default behaviour depth JSON Formatter feat: add option to change default behaviour of JSONFormatter max depth May 30, 2025
@michalsn michalsn merged commit fa1178d into codeigniter4:4.7 May 31, 2025
49 of 50 checks passed
@michalsn
Copy link
Member

@ddevsr Thanks!

@ddevsr ddevsr deleted the json-depth-option branch May 31, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
4.7 enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddevsr @paulbalandan @michalsn