Skip to content

docs: run rector for fix rector errors #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

datamweb
Copy link
Collaborator

@datamweb datamweb commented Apr 5, 2024

Description
See https://github.com/codeigniter4/shield/actions/runs/8571440801/job/23491670281?pr=1084

1) src/Filters/AuthRates.php:58

    ---------- begin diff ----------
@@ @@
     /**
      * We don't have anything to do here.
      *
-     * @param Response|ResponseInterface $response
      * @param array|null                 $arguments
      */
     public function after(RequestInterface $request, ResponseInterface $response, $arguments = null): void
    ----------- end diff -----------

Applied rules:
 * RemoveUselessParamTagRector

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member

@kenjis similar to codeigniter4/CodeIgniter4#8701 could you verify it?

@kenjis kenjis changed the title chore: run rector for fix rector errors docs: run rector for fix rector errors Apr 5, 2024
@kenjis kenjis merged commit b06179a into codeigniter4:dependabot/composer/rector/rector-1.0.4 Apr 5, 2024
@kenjis
Copy link
Member

kenjis commented Apr 5, 2024

I didn't notice this PR was merged into the PR that dependabot created.

We do not accept merge commits in PRs, so the GitHub Action check failed by the merge commit.
So I told dependabot to rebase, but cannot rebase because of the commit.
So I told dependabot to recreate. Then the changes in this PR has gone.

@datamweb The workflow did not work. So send PR like this to develop in the future.

@datamweb datamweb deleted the dependabot/composer/rector/rector-1.0.4 branch April 6, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants