Skip to content

Commit 373c340

Browse files
author
iclsrc
committed
Merge from 'sycl' to 'sycl-web'
2 parents 6df6591 + 5788b98 commit 373c340

34 files changed

+1538
-210
lines changed

CONTRIBUTING.md

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,12 +77,23 @@ for more information.
7777
- Create a personal fork of the project on GitHub
7878
- For the DPC++ Compiler project, use **sycl** branch as baseline for your
7979
changes. See [Get Started Guide](sycl/doc/GetStartedGuide.md).
80-
- Prepare your patch (follow
81-
[LLVM coding standards](https://llvm.org/docs/CodingStandards.html)).
82-
[clang-format](https://clang.llvm.org/docs/ClangFormat.html) and [clang-tidy](
83-
https://clang.llvm.org/extra/clang-tidy/) tools can be integrated into your
84-
workflow to ensure formatting and stylistic compliance of your changes.
80+
- Prepare your patch
81+
- follow [LLVM coding standards](https://llvm.org/docs/CodingStandards.html)
82+
- [clang-format](https://clang.llvm.org/docs/ClangFormat.html) and
83+
[clang-tidy](https://clang.llvm.org/extra/clang-tidy/) tools can be integrated into your
84+
workflow to ensure formatting and stylistic compliance of your changes.
85+
- use
86+
```
87+
./clang/tools/clang-format/git-clang-format `git merge-base origin/sycl HEAD`
88+
```
89+
to check the format of your current changes against the `origin/sycl` branch.
90+
- `-f` to also correct unstaged changes
91+
- `--diff` to only print the diff without applying
8592
- Build the project and run all tests.
93+
- complete test suite: `python buildbot/check.py`
94+
- sycl test suite `python buildbot/check.py -t test-sycl`
95+
- run only "mytest" test `python buildbot/check.py -t test-sycl-mytest`
96+
- if necessary, use `-o $LLVM_BUILD_DIR` to specify the llvm build directory
8697
8798
### Commit message
8899

sycl/include/CL/sycl/builtins.hpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,7 @@ namespace sycl {
2424
#else
2525
namespace __sycl_std = __host_std;
2626
#endif
27-
} // namespace sycl
28-
} // __SYCL_INLINE_NAMESPACE(cl)
2927

30-
__SYCL_INLINE_NAMESPACE(cl) {
31-
namespace sycl {
3228
/* ----------------- 4.13.3 Math functions. ---------------------------------*/
3329
// genfloat acos (genfloat x)
3430
template <typename T>
@@ -731,7 +727,8 @@ detail::enable_if_t<detail::is_geninteger<T>::value, T> clz(T x) __NOEXC {
731727
namespace intel {
732728
// geninteger ctz (geninteger x)
733729
template <typename T>
734-
detail::enable_if_t<detail::is_geninteger<T>::value, T> ctz(T x) __NOEXC {
730+
sycl::detail::enable_if_t<sycl::detail::is_geninteger<T>::value, T>
731+
ctz(T x) __NOEXC {
735732
return __sycl_std::__invoke_ctz<T>(x);
736733
}
737734
} // namespace intel

sycl/include/CL/sycl/detail/cg.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class interop_handler {
4646

4747
public:
4848
using QueueImplPtr = std::shared_ptr<detail::queue_impl>;
49-
using ReqToMem = std::pair<detail::Requirement*, pi_mem>;
49+
using ReqToMem = std::pair<detail::Requirement *, pi_mem>;
5050

5151
interop_handler(std::vector<ReqToMem> MemObjs, QueueImplPtr Queue)
5252
: MQueue(std::move(Queue)), MMemObjs(std::move(MemObjs)) {}

sycl/include/CL/sycl/detail/pi.hpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,9 @@ template <PiApiKind PiApiOffset> struct PiFuncInfo {};
142142

143143
#define _PI_API(api) \
144144
template <> struct PiFuncInfo<PiApiKind::api> { \
145+
using FuncPtrT = decltype(&::api); \
145146
inline std::string getFuncName() { return #api; } \
146-
inline decltype(&::api) getFuncPtr(PiPlugin MPlugin) { \
147+
inline FuncPtrT getFuncPtr(PiPlugin MPlugin) { \
147148
return MPlugin.PiFunctionTable.api; \
148149
} \
149150
};

0 commit comments

Comments
 (0)