Skip to content

Commit 490b556

Browse files
committed
[libc++] Make sure we don't attempt to run check-cxx-abilist when libc++ doesn't define new/delete
That would make the test fail spuriously because we don't generate an ABI list for that configuration.
1 parent 2d761a3 commit 490b556

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

libcxx/lib/abi/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ if (EXISTS "${ABILIST_FILE}"
2222
AND ("${LIBCXX_CXX_ABI_LIBNAME}" STREQUAL "libcxxabi" OR
2323
(APPLE AND "${LIBCXX_CXX_ABI_LIBNAME}" STREQUAL "default"))
2424
AND NOT LIBCXX_ABI_UNSTABLE
25-
AND LIBCXX_ENABLE_EXCEPTIONS)
25+
AND LIBCXX_ENABLE_EXCEPTIONS
26+
AND LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS)
2627
add_custom_target(check-cxx-abilist
2728
${SYMDIFF_EXE} --only-stdlib-symbols --strict ${ABILIST_FILE}
2829
$<TARGET_SONAME_FILE:cxx_shared>

0 commit comments

Comments
 (0)