Skip to content

Commit 7bc944c

Browse files
committed
Revert "[clang][Fuchsia] Add relative-vtables multilib"
This reverts commit fdbd84c. Reverting due to failing CI builders for Fuchsia's toolchain: https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-linux-x64/b8862150211240186992?
1 parent d928dfc commit 7bc944c

File tree

7 files changed

+1
-37
lines changed

7 files changed

+1
-37
lines changed

clang/cmake/caches/Fuchsia-stage2.cmake

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -211,24 +211,14 @@ if(FUCHSIA_SDK)
211211
set(RUNTIMES_${target}-unknown-fuchsia+asan+noexcept_LIBCXXABI_ENABLE_EXCEPTIONS OFF CACHE BOOL "")
212212
set(RUNTIMES_${target}-unknown-fuchsia+asan+noexcept_LIBCXX_ENABLE_EXCEPTIONS OFF CACHE BOOL "")
213213

214-
set(RUNTIMES_${target}-unknown-fuchsia+relative-vtables_LLVM_BUILD_COMPILER_RT OFF CACHE BOOL "")
215-
set(RUNTIMES_${target}-unknown-fuchsia+relative-vtables_CMAKE_CXX_FLAGS "${RUNTIMES_${target}-unknown-fuchsia+relative-vtables_CMAKE_CXX_FLAGS} -Xclang -fexperimental-relative-c++-abi-vtables" CACHE STRING "")
216-
217-
set(RUNTIMES_${target}-unknown-fuchsia+relative-vtables+noexcept_LLVM_BUILD_COMPILER_RT OFF CACHE BOOL "")
218-
set(RUNTIMES_${target}-unknown-fuchsia+relative-vtables+noexcept_CMAKE_CXX_FLAGS "${RUNTIMES_${target}-unknown-fuchsia+relative-vtables+noexcept_CMAKE_CXX_FLAGS} -Xclang -fexperimental-relative-c++-abi-vtables" CACHE STRING "")
219-
set(RUNTIMES_${target}-unknown-fuchsia+relative-vtables+noexcept_LIBCXXABI_ENABLE_EXCEPTIONS OFF CACHE BOOL "")
220-
set(RUNTIMES_${target}-unknown-fuchsia+relative-vtables+noexcept_LIBCXX_ENABLE_EXCEPTIONS OFF CACHE BOOL "")
221-
222214
# Use .build-id link.
223215
list(APPEND RUNTIME_BUILD_ID_LINK "${target}-unknown-fuchsia")
224216
endforeach()
225217

226-
set(LLVM_RUNTIME_MULTILIBS "asan;noexcept;asan+noexcept;relative-vtables;relative-vtables+noexcept" CACHE STRING "")
218+
set(LLVM_RUNTIME_MULTILIBS "asan;noexcept;asan+noexcept" CACHE STRING "")
227219
set(LLVM_RUNTIME_MULTILIB_asan_TARGETS "x86_64-unknown-fuchsia;aarch64-unknown-fuchsia" CACHE STRING "")
228220
set(LLVM_RUNTIME_MULTILIB_noexcept_TARGETS "x86_64-unknown-fuchsia;aarch64-unknown-fuchsia" CACHE STRING "")
229221
set(LLVM_RUNTIME_MULTILIB_asan+noexcept_TARGETS "x86_64-unknown-fuchsia;aarch64-unknown-fuchsia" CACHE STRING "")
230-
set(LLVM_RUNTIME_MULTILIB_relative-vtables_TARGETS "x86_64-unknown-fuchsia;aarch64-unknown-fuchsia" CACHE STRING "")
231-
set(LLVM_RUNTIME_MULTILIB_relative-vtables+noexcept_TARGETS "x86_64-unknown-fuchsia;aarch64-unknown-fuchsia" CACHE STRING "")
232222
endif()
233223

234224
set(LLVM_BUILTIN_TARGETS "${BUILTIN_TARGETS}" CACHE STRING "")

clang/lib/Driver/ToolChains/Fuchsia.cpp

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -210,13 +210,6 @@ Fuchsia::Fuchsia(const Driver &D, const llvm::Triple &Triple,
210210
.flag("+fsanitize=address")
211211
.flag("-fexceptions")
212212
.flag("+fno-exceptions"));
213-
// Use the relative vtables ABI.
214-
Multilibs.push_back(Multilib("relative-vtables", {}, {}, 4)
215-
.flag("+fexperimental-relative-c++-abi-vtables"));
216-
Multilibs.push_back(Multilib("relative-vtables+noexcept", {}, {}, 5)
217-
.flag("+fexperimental-relative-c++-abi-vtables")
218-
.flag("-fexceptions")
219-
.flag("+fno-exceptions"));
220213
Multilibs.FilterOut([&](const Multilib &M) {
221214
std::vector<std::string> RD = FilePaths(M);
222215
return std::all_of(RD.begin(), RD.end(), [&](std::string P) {
@@ -229,13 +222,6 @@ Fuchsia::Fuchsia(const Driver &D, const llvm::Triple &Triple,
229222
Args.hasFlag(options::OPT_fexceptions, options::OPT_fno_exceptions, true),
230223
"fexceptions", Flags);
231224
addMultilibFlag(getSanitizerArgs().needsAsanRt(), "fsanitize=address", Flags);
232-
233-
addMultilibFlag(
234-
Args.hasFlag(options::OPT_fexperimental_relative_cxx_abi_vtables,
235-
options::OPT_fno_experimental_relative_cxx_abi_vtables,
236-
/*default=*/false),
237-
"fexperimental-relative-c++-abi-vtables", Flags);
238-
239225
Multilibs.setFilePathsCallback(FilePaths);
240226

241227
if (Multilibs.select(Flags, SelectedMultilib))

clang/test/Driver/Inputs/basic_fuchsia_tree/lib/aarch64-fuchsia/c++/relative-vtables+noexcept/libc++.so

Whitespace-only changes.

clang/test/Driver/Inputs/basic_fuchsia_tree/lib/aarch64-fuchsia/c++/relative-vtables/libc++.so

Whitespace-only changes.

clang/test/Driver/Inputs/basic_fuchsia_tree/lib/x86_64-fuchsia/c++/relative-vtables+noexcept/libc++.so

Whitespace-only changes.

clang/test/Driver/Inputs/basic_fuchsia_tree/lib/x86_64-fuchsia/c++/relative-vtables/libc++.so

Whitespace-only changes.

clang/test/Driver/fuchsia.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -86,20 +86,8 @@
8686
// RUN: -resource-dir=%S/Inputs/resource_dir_with_per_target_subdir \
8787
// RUN: -fuse-ld=lld 2>&1\
8888
// RUN: | FileCheck %s -check-prefixes=CHECK-MULTILIB-X86,CHECK-MULTILIB-ASAN-NOEXCEPT-X86
89-
// RUN: %clangxx %s -### --target=x86_64-fuchsia -fexperimental-relative-c++-abi-vtables \
90-
// RUN: -ccc-install-dir %S/Inputs/basic_fuchsia_tree/bin \
91-
// RUN: -resource-dir=%S/Inputs/resource_dir_with_per_target_subdir \
92-
// RUN: -fuse-ld=lld 2>&1\
93-
// RUN: | FileCheck %s -check-prefixes=CHECK-MULTILIB-X86,CHECK-MULTILIB-RELATIVE-VTABLES-X86
94-
// RUN: %clangxx %s -### --target=x86_64-fuchsia -fexperimental-relative-c++-abi-vtables -fno-exceptions \
95-
// RUN: -ccc-install-dir %S/Inputs/basic_fuchsia_tree/bin \
96-
// RUN: -resource-dir=%S/Inputs/resource_dir_with_per_target_subdir \
97-
// RUN: -fuse-ld=lld 2>&1\
98-
// RUN: | FileCheck %s -check-prefixes=CHECK-MULTILIB-X86,CHECK-MULTILIB-RELATIVE-VTABLES-NOEXCEPT-X86
9989
// CHECK-MULTILIB-X86: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]"
10090
// CHECK-MULTILIB-ASAN-X86: "-L{{.*}}{{/|\\\\}}..{{/|\\\\}}lib{{/|\\\\}}x86_64-fuchsia{{/|\\\\}}c++{{/|\\\\}}asan"
10191
// CHECK-MULTILIB-NOEXCEPT-X86: "-L{{.*}}{{/|\\\\}}..{{/|\\\\}}lib{{/|\\\\}}x86_64-fuchsia{{/|\\\\}}c++{{/|\\\\}}noexcept"
10292
// CHECK-MULTILIB-ASAN-NOEXCEPT-X86: "-L{{.*}}{{/|\\\\}}..{{/|\\\\}}lib{{/|\\\\}}x86_64-fuchsia{{/|\\\\}}c++{{/|\\\\}}asan+noexcept"
103-
// CHECK-MULTILIB-RELATIVE-VTABLES-X86: "-L{{.*}}{{/|\\\\}}..{{/|\\\\}}lib{{/|\\\\}}x86_64-fuchsia{{/|\\\\}}c++{{/|\\\\}}relative-vtables"
104-
// CHECK-MULTILIB-RELATIVE-VTABLES-NOEXCEPT-X86: "-L{{.*}}{{/|\\\\}}..{{/|\\\\}}lib{{/|\\\\}}x86_64-fuchsia{{/|\\\\}}c++{{/|\\\\}}relative-vtables+noexcept"
10593
// CHECK-MULTILIB-X86: "-L{{.*}}{{/|\\\\}}..{{/|\\\\}}lib{{/|\\\\}}x86_64-fuchsia{{/|\\\\}}c++"

0 commit comments

Comments
 (0)