Merge from 'master' to 'sycl-web' (#3)

  CONFLICT (content): Merge conflict in clang/include/clang/Basic/DiagnosticSemaKinds.td

Author: Valery N Dmitriev

.gitignore

@@ -56,3 +56,8 @@ autoconf/autom4te.cache
 .vs
 # clangd index
 .clangd
+# static analyzer regression testing project files
+/clang/utils/analyzer/projects/*/CachedSource
+/clang/utils/analyzer/projects/*/PatchedSource
+/clang/utils/analyzer/projects/*/ScanBuildResults
+/clang/utils/analyzer/projects/*/RefScanBuildResults

clang-tools-extra/clang-change-namespace/CMakeLists.txt

@@ -5,6 +5,9 @@ set(LLVM_LINK_COMPONENTS
 
 add_clang_library(clangChangeNamespace
   ChangeNamespace.cpp
+
+  DEPENDS
+  omp_gen
 )
 
 clang_target_link_libraries(clangChangeNamespace

clang-tools-extra/clang-doc/CMakeLists.txt

@@ -15,6 +15,9 @@ add_clang_library(clangDoc
   Representation.cpp
   Serialize.cpp
   YAMLGenerator.cpp
+
+  DEPENDS
+  omp_gen
 )
 
 clang_target_link_libraries(clangDoc

clang-tools-extra/clang-include-fixer/CMakeLists.txt

@@ -12,6 +12,9 @@ add_clang_library(clangIncludeFixer
 
   LINK_LIBS
   findAllSymbols
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangIncludeFixer

clang-tools-extra/clang-include-fixer/find-all-symbols/CMakeLists.txt

@@ -12,6 +12,9 @@ add_clang_library(findAllSymbols
   PragmaCommentHandler.cpp
   STLPostfixHeaderMap.cpp
   SymbolInfo.cpp
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(findAllSymbols

clang-tools-extra/clang-include-fixer/plugin/CMakeLists.txt

@@ -10,4 +10,7 @@ add_clang_library(clangIncludeFixerPlugin
   clangSema
   clangTooling
   ${LLVM_PTHREAD_LIB}
+
+  DEPENDS
+  omp_gen
   )

clang-tools-extra/clang-move/CMakeLists.txt

@@ -6,6 +6,9 @@ set(LLVM_LINK_COMPONENTS
 add_clang_library(clangMove
   Move.cpp
   HelperDeclRefGraph.cpp
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangMove

clang-tools-extra/clang-query/CMakeLists.txt

@@ -7,6 +7,9 @@ set(LLVM_LINK_COMPONENTS
 add_clang_library(clangQuery
   Query.cpp
   QueryParser.cpp
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangQuery

clang-tools-extra/clang-reorder-fields/CMakeLists.txt

@@ -5,6 +5,9 @@ set(LLVM_LINK_COMPONENTS
 
 add_clang_library(clangReorderFields
   ReorderFieldsAction.cpp
+
+  DEPENDS
+  omp_gen
 )
 
 clang_target_link_libraries(clangReorderFields

clang-tools-extra/clang-tidy/CMakeLists.txt

@@ -15,6 +15,7 @@ add_clang_library(clangTidy
 
   DEPENDS
   ClangSACheckers
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidy

clang-tools-extra/clang-tidy/abseil/CMakeLists.txt

@@ -28,6 +28,9 @@ add_clang_library(clangTidyAbseilModule
   LINK_LIBS
   clangTidy
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyAbseilModule

clang-tools-extra/clang-tidy/android/CMakeLists.txt

@@ -25,6 +25,9 @@ add_clang_library(clangTidyAndroidModule
   LINK_LIBS
   clangTidy
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyAndroidModule

clang-tools-extra/clang-tidy/boost/CMakeLists.txt

@@ -10,6 +10,9 @@ add_clang_library(clangTidyBoostModule
   LINK_LIBS
   clangTidy
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyBoostModule

clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt

@@ -62,6 +62,9 @@ add_clang_library(clangTidyBugproneModule
   clangTidy
   clangTidyCppCoreGuidelinesModule
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyBugproneModule

clang-tools-extra/clang-tidy/cert/CMakeLists.txt

@@ -28,6 +28,9 @@ add_clang_library(clangTidyCERTModule
   clangTidyPerformanceModule
   clangTidyReadabilityModule
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyCERTModule

clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt

@@ -32,6 +32,9 @@ add_clang_library(clangTidyCppCoreGuidelinesModule
   clangTidyModernizeModule
   clangTidyReadabilityModule
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyCppCoreGuidelinesModule

clang-tools-extra/clang-tidy/darwin/CMakeLists.txt

@@ -11,6 +11,9 @@ add_clang_library(clangTidyDarwinModule
   LINK_LIBS
   clangTidy
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyDarwinModule

clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt

@@ -17,6 +17,9 @@ add_clang_library(clangTidyFuchsiaModule
   clangTidy
   clangTidyGoogleModule
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyFuchsiaModule

clang-tools-extra/clang-tidy/google/CMakeLists.txt

@@ -27,6 +27,9 @@ add_clang_library(clangTidyGoogleModule
   clangTidy
   clangTidyReadabilityModule
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyGoogleModule

clang-tools-extra/clang-tidy/hicpp/CMakeLists.txt

@@ -20,6 +20,9 @@ add_clang_library(clangTidyHICPPModule
   clangTidyPerformanceModule
   clangTidyReadabilityModule
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyHICPPModule

clang-tools-extra/clang-tidy/linuxkernel/CMakeLists.txt

@@ -10,6 +10,9 @@ add_clang_library(clangTidyLinuxKernelModule
   LINK_LIBS
   clangTidy
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyLinuxKernelModule

clang-tools-extra/clang-tidy/llvm/CMakeLists.txt

@@ -15,6 +15,9 @@ add_clang_library(clangTidyLLVMModule
   clangTidy
   clangTidyReadabilityModule
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyLLVMModule

clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt

@@ -13,6 +13,9 @@ add_clang_library(clangTidyLLVMLibcModule
   clangTidy
   clangTidyPortabilityModule
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyLLVMLibcModule

clang-tools-extra/clang-tidy/misc/CMakeLists.txt

@@ -23,6 +23,9 @@ add_clang_library(clangTidyMiscModule
   LINK_LIBS
   clangTidy
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyMiscModule

clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

@@ -43,6 +43,9 @@ add_clang_library(clangTidyModernizeModule
   clangTidy
   clangTidyReadabilityModule
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyModernizeModule

clang-tools-extra/clang-tidy/mpi/CMakeLists.txt

@@ -11,6 +11,9 @@ add_clang_library(clangTidyMPIModule
   LINK_LIBS
   clangTidy
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyMPIModule

clang-tools-extra/clang-tidy/objc/CMakeLists.txt

@@ -16,6 +16,9 @@ add_clang_library(clangTidyObjCModule
   LINK_LIBS
   clangTidy
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyObjCModule

clang-tools-extra/clang-tidy/openmp/CMakeLists.txt

@@ -11,6 +11,9 @@ add_clang_library(clangTidyOpenMPModule
   LINK_LIBS
   clangTidy
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyOpenMPModule

clang-tools-extra/clang-tidy/performance/CMakeLists.txt

@@ -23,6 +23,9 @@ add_clang_library(clangTidyPerformanceModule
   LINK_LIBS
   clangTidy
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyPerformanceModule

clang-tools-extra/clang-tidy/plugin/CMakeLists.txt

@@ -4,6 +4,9 @@ add_clang_library(clangTidyPlugin
   LINK_LIBS
   clangTidy
   ${ALL_CLANG_TIDY_CHECKS}
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyPlugin

clang-tools-extra/clang-tidy/portability/CMakeLists.txt

@@ -11,6 +11,9 @@ add_clang_library(clangTidyPortabilityModule
   LINK_LIBS
   clangTidy
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyPortabilityModule

clang-tools-extra/clang-tidy/readability/CMakeLists.txt

@@ -47,6 +47,9 @@ add_clang_library(clangTidyReadabilityModule
   LINK_LIBS
   clangTidy
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyReadabilityModule

clang-tools-extra/clang-tidy/tool/CMakeLists.txt

@@ -15,6 +15,9 @@ add_clang_library(clangTidyMain
   LINK_LIBS
   clangTidy
   ${ALL_CLANG_TIDY_CHECKS}
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyMain

clang-tools-extra/clang-tidy/utils/CMakeLists.txt

@@ -23,6 +23,9 @@ add_clang_library(clangTidyUtils
 
   LINK_LIBS
   clangTidy
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyUtils

clang-tools-extra/clang-tidy/zircon/CMakeLists.txt

@@ -10,6 +10,9 @@ add_clang_library(clangTidyZirconModule
   LINK_LIBS
   clangTidy
   clangTidyUtils
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangTidyZirconModule

clang-tools-extra/clangd/CMakeLists.txt

@@ -100,6 +100,9 @@ add_clang_library(clangDaemon
   clangTidy
   ${LLVM_PTHREAD_LIB}
   ${ALL_CLANG_TIDY_CHECKS}
+
+  DEPENDS
+  omp_gen
   )
 
 clang_target_link_libraries(clangDaemon

clang-tools-extra/clangd/Hover.cpp

@@ -341,7 +341,10 @@ llvm::Optional<std::string> printExprValue(const Expr *E,
       T->isFunctionReferenceType())
     return llvm::None;
   // Attempt to evaluate. If expr is dependent, evaluation crashes!
-  if (E->isValueDependent() || !E->EvaluateAsRValue(Constant, Ctx))
+  if (E->isValueDependent() || !E->EvaluateAsRValue(Constant, Ctx) ||
+      // Disable printing for record-types, as they are usually confusing and
+      // might make clang crash while printing the expressions.
+      Constant.Val.isStruct() || Constant.Val.isUnion())
     return llvm::None;
 
   // Show enums symbolically, not numerically like APValue::printPretty().
@@ -353,7 +356,7 @@ llvm::Optional<std::string> printExprValue(const Expr *E,
       if (ECD->getInitVal() == Val)
         return llvm::formatv("{0} ({1})", ECD->getNameAsString(), Val).str();
   }
-  return Constant.Val.getAsString(Ctx, E->getType());
+  return Constant.Val.getAsString(Ctx, T);
 }
 
 llvm::Optional<std::string> printExprValue(const SelectionTree::Node *N,

clang-tools-extra/clangd/index/Background.cpp

@@ -103,10 +103,9 @@ BackgroundIndex::BackgroundIndex(
           CDB.watch([&](const std::vector<std::string> &ChangedFiles) {
             enqueue(ChangedFiles);
           })) {
-  assert(Rebuilder.TUsBeforeFirstBuild > 0 &&
-         "Thread pool size can't be zero.");
+  assert(ThreadPoolSize > 0 && "Thread pool size can't be zero.");
   assert(this->IndexStorageFactory && "Storage factory can not be null!");
-  for (unsigned I = 0; I < Rebuilder.TUsBeforeFirstBuild; ++I) {
+  for (unsigned I = 0; I < ThreadPoolSize; ++I) {
     ThreadPool.runAsync("background-worker-" + llvm::Twine(I + 1), [this] {
       WithContext Ctx(this->BackgroundContext.clone());
       Queue.work([&] { Rebuilder.idle(); });

clang-tools-extra/clangd/index/Background.h

@@ -135,7 +135,9 @@ class BackgroundIndex : public SwapIndex {
       Context BackgroundContext, const ThreadsafeFS &,
       const GlobalCompilationDatabase &CDB,
       BackgroundIndexStorage::Factory IndexStorageFactory,
-      size_t ThreadPoolSize = 0, // 0 = use all hardware threads
+      // Arbitrary value to ensure some concurrency in tests.
+      // In production an explicit value is passed.
+      size_t ThreadPoolSize = 4,
       std::function<void(BackgroundQueue::Stats)> OnProgress = nullptr);
   ~BackgroundIndex(); // Blocks while the current task finishes.